Regenerate core, expose privateHost and temperature
#348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions and ChatCompletionOptions, update models enums for assistant
austin-denoble
commented
Jun 14, 2025
| @@ -22,9 +22,9 @@ | |||
| "lint": "eslint src/ --ext .ts", | |||
| "repl": "npm run build && node utils/replInit.ts", | |||
| "test:integration:node": "TEST_ENV=node jest src/integration/ -c jest.config.integration-node.js --detectOpenHandles --runInBand --bail --forceExit", | |||
| "test:integration-local:node": "TEST_ENV=node node src/integration/integrationRunner.js", | |||
There was a problem hiding this comment.
Fixing local runner since the script was moved previously.
austin-denoble
commented
Jun 14, 2025
| throw new Error( | ||
| 'Invalid model specified. Must be one of "gpt-4o" or "claude-3-5-sonnet"' | ||
| `Invalid model specified. Must be one of ${allowedModels |
There was a problem hiding this comment.
Moving away from hard-coding this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few new fields which were ported to the
2025-04spec:temperature(Assistant chat / chatCompletion, chatStreaming, chatCompletionStreaming)privateHost(IndexModel)Solution
temperature.ChatOptionsandChatCompletionOptions.Type of Change
Test Plan
CI - external app tests, unit tests, integration tests